This repository was archived by the owner on Oct 29, 2025. It is now read-only.
fix: throw on missing icon - #75
Closed
tomasciccola wants to merge 1 commit into
Closed
Conversation
Contributor
|
Discussed this a bit elsewhere but I think the existing behavior of this module is generally correct compared to the import implementation that's done in core. Let's defer to the outcome of digidem/comapeo-core#1011 before potentially making a change here |
Contributor
|
This is now addressed in the new |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we fail HARD when importing a categories file that has a preset without an icon in comapeo-core (see) we should also maintain this logic on the settings builder so that we don't trip users (because we also don't actually show config-import warnings on the CoMapeo UI).
This is a possible solution, but we can also fix this issue on comapeo-core, by just skipping the invalid preset (which I don't think is a good solution because is also not transparent to users until we start showing this config-import warnings)